-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating third party docs page to include npm packages and products #6920
Open
johnsimons
wants to merge
28
commits into
master
Choose a base branch
from
john/thrid
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+806
−669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the Setup project always fails
johnsimons
force-pushed
the
john/thrid
branch
from
December 2, 2024 07:28
9a52ddf
to
92e3a84
Compare
johnsimons
force-pushed
the
john/thrid
branch
from
December 2, 2024 09:12
3d17219
to
299c396
Compare
johnsimons
force-pushed
the
john/thrid
branch
from
December 2, 2024 22:50
256bb64
to
3e4cd77
Compare
@PhilBastian I am not 100% sure whether the title of the page should still be "Thrid-party licenses", thoughts? |
I will update the licenses text to the new URL once this is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all the scripts to generate the 3rd party list to also include ServiceControl and ServicePulse.
The 3rd party list moves from
/nservicebus/upgrades/third-party-licenses
to/platform/third-party-licenses
.As part of this change we also improved the diff viewing when the changes are large, now we create a
changes.patch
artifact that is easier to review and apply manually.This also changes the layout of the page, the page changes to a simple list of all 3rd party libs that are used for all Particular software: